[VM] rename vm catchable and uncatchable exceptions #3538
Conversation
|
@roman-khimov @shargon please take a look, this is what i want to do with the exception currently. It just make it clear what the exception are and enfoce an exception message. If you think it is good to go, i will finish this pr. I think nothing will be influenced. |
|
Well, need to udpate UT still~~~ UTs are affected since exception type are different |
| @@ -59,7 +59,7 @@ public class ExecutionEngine : IDisposable | |||
| /// <summary> | |||
| /// The VM object representing the uncaught exception. | |||
| /// </summary> | |||
| public StackItem? UncaughtException { get; internal set; } | |||
| public StackItem? UncaughtVMCatchableException { get; internal set; } | |||
There was a problem hiding this comment.
I think that we don't need to rename this one
There was a problem hiding this comment.
not a problem, if you think this pr is ok, will revert it.
There was a problem hiding this comment.
Yes, you want to throw only VMXXExceptions, ins't it? maybe we should have and interface for valid exceptions
There was a problem hiding this comment.
something like IVMException , And catcheable and UnCatcheable
| if (string.IsNullOrEmpty(message)) | ||
| throw new ArgumentException("Message cannot be null or empty.", nameof(message)); |
There was a problem hiding this comment.
I prefer to avoid this, this error will be throw during runtime, is not a warning for us
| if (string.IsNullOrEmpty(message)) | ||
| throw new ArgumentException("Message cannot be null or empty.", nameof(message)); |
Description
This pr tries to improve the VM exception type and inforamtion, making it easier to understand the VM exception.
Fixes # #3536
Type of change
Test Configuration:
Checklist: